Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multithreaded bulk import #235

Merged
merged 26 commits into from
Dec 19, 2024

Conversation

tamassoltesz
Copy link
Contributor

@tamassoltesz tamassoltesz commented Nov 27, 2024

Summary of change

Postgres implementation of bulk import.

Related issues

supertokens/supertokens-core#912

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • When adding new recipes, ensure that its performance is being measured in the OneMillionUsersTest

Remaining TODOs for this PR

  • Item1
  • Item2

@tamassoltesz tamassoltesz changed the title Feat/multithreaded bulk import feat: multithreaded bulk import Nov 27, 2024
@tamassoltesz tamassoltesz marked this pull request as ready for review November 27, 2024 12:54
@sattvikc sattvikc merged commit 0b11cd0 into feat/bulk-import-base Dec 19, 2024
2 of 3 checks passed
@sattvikc sattvikc deleted the feat/multithreaded-bulk-import branch December 19, 2024 08:43
sattvikc added a commit that referenced this pull request Dec 19, 2024
* feat: multithreaded bulk import (#235)

* feat: Add BulkImport APIs and cron

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: Update version and changelog

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: removing restriction of connection pool size for bulk import

* fix: actually closing the connection

* fix: add bulk import retry logic for postgres too

* fix: fix failing tests

* chore: current state save

* fix: fixing merge error with changelog

* feat: bulk inserting the bulk migration data

* fix: fixes and error handling changes

* fix: fixing tests

* chore: changelog and build version update

* fix: handling app/tenant not found

* fix: review fix

---------

Co-authored-by: Ankit Tiwari <[email protected]>

* Update pluginInterfaceSupported.json

---------

Co-authored-by: Tamas Soltesz <[email protected]>
Co-authored-by: Ankit Tiwari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants